Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Boundary treatment #98

Draft
wants to merge 48 commits into
base: development
Choose a base branch
from
Draft

New Boundary treatment #98

wants to merge 48 commits into from

Conversation

CyprienBosserelle
Copy link
Owner

@CyprienBosserelle CyprienBosserelle commented Nov 30, 2023 •
edited
Loading

Using flux term for new boundary treatment

Proof of concept

  • New wall bnd for halo flux on GPU
  • Same for CPU

Implementation

  • apply wall boundary metafunction designed for AOI wall to model BBox
  • Implement new segment based bnd
  • New abs flux for model BBox
  • Fix Warmstart

Testing

  • New CI test for wall bnd of AOI
  • New CI test for wall of BBox

Docs

  • Full documentation page with example
  • Demo of stability/instability and if it solves the problem

@CyprienBosserelle CyprienBosserelle marked this pull request as draft November 30, 2023 22:48
@CyprienBosserelle
Fix ABS1D Q calculations
91d9192
@CyprienBosserelle
ABS1DQ clean function call and add qmean
c8167a3
@CyprienBosserelle
ABS1DQ Fix h miising in fctn call
335e8aa
@CyprienBosserelle
Add New "NoFlux" Bnd to BBox bnd
21f188c
@CyprienBosserelle
Fix case on header call
34fb4a8
@CyprienBosserelle
fix on left and bot wall
5fd3ce4
@CyprienBosserelle
make test for all side
7c205b8
@CyprienBosserelle
u v bnd fix
4ad3373
@CyprienBosserelle
add comment to test
a19292d
@CyprienBosserelle
clean up the function
3ecfeb0
@CyprienBosserelle
Update Boundary.h
2f38ef1
@CyprienBosserelle
implement handling fcnt for flux bnd
660582f
@CyprienBosserelle
Fix wall bnd for Left and right side
87b56e8 
Also improve the test!
@CyprienBosserelle
Update Testing.cu
f194155
@CyprienBosserelle
fix for flux test-demo
c72140c
@CyprienBosserelle
Update Boundary.cu
b3ba6d4
@CyprienBosserelle
build new structures to support AOI bnds
f429ed3
@CyprienBosserelle
Add workflow for new bnd initialisation
c3f349c
@CyprienBosserelle
Update InitialConditions.cu
c9517a0
@CyprienBosserelle
Start the init bnd functionality
c7c72ed
@CyprienBosserelle
Fix compile error forcing.h
5b4d79f
@CyprienBosserelle
Update InitialConditions.cu
3712164
@CyprienBosserelle
fix to compile
d71e62e
@CyprienBosserelle
Copy link
Owner Author

This is on-hold until testing with new bnd complete

@CyprienBosserelle CyprienBosserelle mentioned this pull request Jun 18, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CyprienBosserelle