Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: New Strategy for ArbitraryTransferFrom Detector #776

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Oct 19, 2024

Trigger only in external / public functions when the argument to from matches the containing function's parameter list. Also make sure msg.sender was not checked anywhere to really know if it's arbitrary

Context: @devtooligan's suggestion

@TilakMaddy TilakMaddy marked this pull request as ready for review October 19, 2024 11:38
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner October 19, 2024 11:38
@TilakMaddy TilakMaddy merged commit 2cda3d3 into dev Oct 19, 2024
12 checks passed
@TilakMaddy TilakMaddy changed the title Fix: Strategy for ArbitraryTransferFrom Detector Fix: New Strategy for ArbitraryTransferFrom Detector Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant