Shorten names (Start of 0.3.2) (#759)

aderyn_core/src/detect/detector.rs

@@ -114,7 +114,7 @@ pub fn get_all_detectors_names() -> Vec<String> {
 #[derive(Debug, PartialEq, EnumString, Display)]
 #[strum(serialize_all = "kebab-case")]
 pub(crate) enum IssueDetectorNamePool {
-    StateVariableCouldBeDeclaredImmutable,
+    StateVariableCouldBeImmutable,
     MultiplePlaceholders,
     StateVariableChangesWithoutEvents,
     MissingInheritance,
@@ -135,7 +135,7 @@ pub(crate) enum IssueDetectorNamePool {
     CentralizationRisk,
     SolmateSafeTransferLib,
     HashCollisionDueToAbiEncodePacked,
-    SignatureMalleabilityDueToRawEcrecover,
+    RawEcrecover,
     DeprecatedOzFunctions,
     UnsafeERC20Functions,
     UnspecificSolidityPragma,
@@ -183,7 +183,7 @@ pub(crate) enum IssueDetectorNamePool {
     UncheckedReturn,
     DangerousUnaryOperator,
     TautologyOrContradiction,
-    DangerousStrictEquailtyOnContractBalance,
+    StrictEquailtyCheckOnContractBalance,
     SignedStorageArray,
     RedundantStatements,
     PublicVariableReadInExternalContext,
@@ -201,7 +201,7 @@ pub(crate) enum IssueDetectorNamePool {
     UninitializedLocalVariable,
     ReturnBomb,
     OutOfOrderRetryable,
-    StateVariableCouldBeDeclaredConstant,
+    StateVariableCouldBeConstant,
     // NOTE: `Undecided` will be the default name (for new bots).
     // If it's accepted, a new variant will be added to this enum before normalizing it in aderyn
     Undecided,
@@ -211,7 +211,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
     // Expects a valid detector_name
     let detector_name = IssueDetectorNamePool::from_str(detector_name).ok()?;
     match detector_name {
-        IssueDetectorNamePool::StateVariableCouldBeDeclaredImmutable => {
+        IssueDetectorNamePool::StateVariableCouldBeImmutable => {
             Some(Box::<StateVariableCouldBeImmutableDetector>::default())
         }
         IssueDetectorNamePool::MultiplePlaceholders => {
@@ -228,7 +228,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         }
         IssueDetectorNamePool::UnusedImport => Some(Box::<UnusedImportDetector>::default()),
         IssueDetectorNamePool::VoidConstructor => Some(Box::<VoidConstructorDetector>::default()),
-        IssueDetectorNamePool::StateVariableCouldBeDeclaredConstant => {
+        IssueDetectorNamePool::StateVariableCouldBeConstant => {
             Some(Box::<StateVariableCouldBeConstantDetector>::default())
         }
         IssueDetectorNamePool::LiteralInsteadOfConstant => {
@@ -287,9 +287,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         IssueDetectorNamePool::HashCollisionDueToAbiEncodePacked => {
             Some(Box::<AvoidAbiEncodePackedDetector>::default())
         }
-        IssueDetectorNamePool::SignatureMalleabilityDueToRawEcrecover => {
-            Some(Box::<EcrecoverDetector>::default())
-        }
+        IssueDetectorNamePool::RawEcrecover => Some(Box::<EcrecoverDetector>::default()),
         IssueDetectorNamePool::DeprecatedOzFunctions => {
             Some(Box::<DeprecatedOZFunctionsDetector>::default())
         }
@@ -406,7 +404,7 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
         IssueDetectorNamePool::TautologyOrContradiction => {
             Some(Box::<TautologyOrContraditionDetector>::default())
         }
-        IssueDetectorNamePool::DangerousStrictEquailtyOnContractBalance => {
+        IssueDetectorNamePool::StrictEquailtyCheckOnContractBalance => {
             Some(Box::<DangerousStrictEqualityOnBalanceDetector>::default())
         }
         IssueDetectorNamePool::SignedStorageArray => {

aderyn_core/src/detect/high/dangerous_strict_equality_balance.rs

@@ -73,7 +73,7 @@ impl IssueDetector for DangerousStrictEqualityOnBalanceDetector {
     }
 
     fn name(&self) -> String {
-        IssueDetectorNamePool::DangerousStrictEquailtyOnContractBalance.to_string()
+        IssueDetectorNamePool::StrictEquailtyCheckOnContractBalance.to_string()
     }
 }
 

aderyn_core/src/detect/low/ecrecover.rs

@@ -49,7 +49,7 @@ impl IssueDetector for EcrecoverDetector {
     }
 
     fn name(&self) -> String {
-        format!("{}", IssueDetectorNamePool::SignatureMalleabilityDueToRawEcrecover)
+        format!("{}", IssueDetectorNamePool::RawEcrecover)
     }
 }
 

aderyn_core/src/detect/low/state_variable_could_be_constant.rs

@@ -106,7 +106,7 @@ impl IssueDetector for StateVariableCouldBeConstantDetector {
     }
 
     fn name(&self) -> String {
-        format!("{}", IssueDetectorNamePool::StateVariableCouldBeDeclaredConstant)
+        format!("{}", IssueDetectorNamePool::StateVariableCouldBeConstant)
     }
 }
 

aderyn_core/src/detect/low/state_variable_could_be_immutable.rs

@@ -148,7 +148,7 @@ impl IssueDetector for StateVariableCouldBeImmutableDetector {
     }
 
     fn name(&self) -> String {
-        format!("{}", IssueDetectorNamePool::StateVariableCouldBeDeclaredImmutable)
+        format!("{}", IssueDetectorNamePool::StateVariableCouldBeImmutable)
     }
 }