Refactor: Tidy some imports and tests #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
force-pushed
the
tidy-imports
branch
2 times, most recently
from
669c00c to
bfc5907
Compare
ValClarkson
approved these changes
Nov 15, 2024
benjaminjb
reviewed
Nov 18, 2024
benjaminjb
approved these changes
Nov 18, 2024
The default unstructured converter does not complain if you try to convert a list to an object or vice versa. It also expects to be called with an empty target object.
Tests already report the line on which an assert fails, and the standard "errors" packages unwraps errors.
We only use these CRD files in Go tests, and Go has already downloaded them as part of the module we import for serializing API objects.
benjaminjb
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two functions to
internal/controller/runtimeto reduce the imports in the pgBackRest controller and adds a linter to keepgithub.com/pkg/errorsout of tests.This also uses
golang.org/x/tools/go/packagesto load VolumeSnapshot CRDs from the (already downloaded) client Go module.