Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging of all server-side errors #127

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

dylan-bourque
Copy link

Highlights:

  • upgrade to Go 1.21
  • switch from using golang.org/x/exp/slog to log/slog
  • refactor logging to support debug, info, and error logs
  • ensure all server-side errors are logged
  • enable change log generation via git-cliff

Closes #113
Closes #114

@dylan-bourque dylan-bourque requested a review from a team November 28, 2023 19:56
Copy link

@jakereps jakereps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one nit and a q 👍

internal/log/logger.go Outdated Show resolved Hide resolved
internal/log/logger.go Outdated Show resolved Hide resolved
@dylan-bourque dylan-bourque requested a review from a team November 29, 2023 21:29
Dylan Bourque added 3 commits November 30, 2023 12:55
update Go version to 1.21
bump GH actions to use Go 1.21
use `log/slog` instead of `golang.org/x/exp/slog`
refactor logging code to support debug, error, and info logs
ensure internal errors are always logged
@dylan-bourque dylan-bourque merged commit 4eb7e82 into main Nov 30, 2023
3 checks passed
@dylan-bourque dylan-bourque deleted the wip-upgrade-to-go-1-21 branch November 30, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Go 1.21 and swap golang.org/x/exp/slog for log/slog Perseus server should log details about errors
4 participants