Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add configurations for rails 7.2, ruby {3.2, 3.3} #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
branches: ['master']
schedule:
- cron: '0 0 * * 0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, consider removing this scheduling. See the notes from active-record_acts-as

workflow_dispatch:

permissions:
contents: read
Expand All @@ -23,12 +24,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.0', '3.1']
activerecord: ['6.0', '6.1', '7.0', '7.1']
ruby-version: ['3.0', '3.1', '3.2', '3.3']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as active-record_acts-as, please just focus the testing for

  • Rails 7.0, 7.1, 7.2
  • Ruby 3.1, 3.2, 3.3

activerecord: ['7.0', '7.1', '7.2']
exclude:
- ruby-version: '3.0'
activerecord: '7.2'
env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.activerecord }}.gemfile
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Ruby
# To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
# change this to (see https://github.com/ruby/setup-ruby#versioning):
Expand Down
1 change: 0 additions & 1 deletion .ruby-version

This file was deleted.

15 changes: 5 additions & 10 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
appraise "rails-6.0" do
gem 'rails', '~> 6.0'
gem "rspec-rails", '~> 5'
end

appraise "rails-6.1" do
gem 'rails', '~> 6.1'
gem "rspec-rails", '>= 6'
end

appraise "rails-7.0" do
gem 'rails', '~> 7.0'
gem "rspec-rails", '>= 6'
Expand All @@ -17,3 +7,8 @@ appraise "rails-7.1" do
gem 'rails', '~> 7.1'
gem "rspec-rails", '>= 6'
end

appraise "rails-7.2" do
gem 'rails', '~> 7.2'
gem "rspec-rails", '>= 6'
end
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
# Changelog

## 3.0.7 (4-9-2024)
* Adi Suryanata Herwana - Support Rails >= 7.2 and Ruby >= 3.3.

## 3.0.6 (24-7-2024)
* Bivan Alzacky Harmanto - Support Rails >= 6.0 and Ruby >= 3.0.

## 3.0.5 (22-8-2017)
* Jonathan Putney - Support Rails 5.0.
* Joel Low - Add additional combinations to Travis build matrix.
Expand Down
6 changes: 3 additions & 3 deletions activerecord-userstamp.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require 'active_record/userstamp/version'
Gem::Specification.new do |s|
s.name = 'activerecord-userstamp'
s.version = ActiveRecord::Userstamp::VERSION
s.authors = ['Bivan Alzacky Harmanto']
s.authors = ['Joel Low', 'Bivan Alzacky Harmanto', 'Adi Suryanata Herwana']
s.email = ['[email protected]']

s.summary = 'Adds magic creator and updater attributes to your ActiveRecord models.'
Expand All @@ -19,15 +19,15 @@ Gem::Specification.new do |s|
s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
s.require_paths = ['lib']

s.add_dependency 'rails', '>= 6'
s.add_dependency 'rails', '>= 7.0'

s.required_ruby_version = ">= 3.0"

s.add_development_dependency 'tzinfo-data' if RUBY_PLATFORM =~ /mswin|mingw/
s.add_development_dependency 'rake'
s.add_development_dependency 'rdoc'
s.add_development_dependency 'simplecov'
s.add_development_dependency 'coveralls'
s.add_development_dependency 'coveralls_reborn'
s.add_development_dependency 'codeclimate-test-reporter'
s.add_development_dependency 'sqlite3', "~> 1.7"
s.add_development_dependency "appraisal", "~> 2.1"
Expand Down
8 changes: 0 additions & 8 deletions gemfiles/rails_6.0.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rails_6.1.gemfile → gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "~> 6.1"
gem "rails", "~> 7.2"
gem "rspec-rails", ">= 6"

gemspec path: "../"
2 changes: 1 addition & 1 deletion lib/active_record/userstamp/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module ActiveRecord; end
module ActiveRecord::Userstamp
VERSION = '3.0.5'
VERSION = '3.0.7'
end