Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback Widgets] Terms and conditions support #486

Merged
merged 3 commits into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 24.4.0
- Added support for Feedback Widget terms and conditions

## 23.12.6
- Mitigated an issue where error tracking could prevent SDK initialization in async mode

Expand Down
2 changes: 1 addition & 1 deletion examples/create_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def setup_react_example():

def setup_angular_example():
print("Creating Angular example...")
os.system("npx @angular/cli new angular-example --defaults")
os.system("npx @angular/cli@next new angular-example --defaults")

# Copy contents of Angular folder over to Angular example
shutil.copytree("Angular", "angular-example/src", dirs_exist_ok=True)
Expand Down
5 changes: 3 additions & 2 deletions lib/countly.js
Original file line number Diff line number Diff line change
Expand Up @@ -3723,11 +3723,12 @@
url += "&platform=" + this.platform;
url += "&app_version=" + this.app_version;
url += "&sdk_version=" + sdkVersion;
var customObjectToSendWithTheWidget = {};
customObjectToSendWithTheWidget.tc = 1; // indicates SDK supports opening links from the widget in a new tab
if (feedbackWidgetSegmentation) {
var customObjectToSendWithTheWidget = {};
customObjectToSendWithTheWidget.sg = feedbackWidgetSegmentation;
url += "&custom=" + JSON.stringify(customObjectToSendWithTheWidget);
}
url += "&custom=" + JSON.stringify(customObjectToSendWithTheWidget);
// Origin is passed to the popup so that it passes it back in the postMessage event
// Only web SDK passes origin and web
url += "&origin=" + passedOrigin;
Expand Down
Loading