Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "-dev" for extra values #163

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Added "-dev" for extra values #163

merged 1 commit into from
Jun 6, 2017

Conversation

JeroenBoersma
Copy link
Contributor

@JeroenBoersma JeroenBoersma commented Jun 6, 2017

After recent events it should be awesome to have different strategies for dev and production.
When working locally you can now have any extra parameter, append a -dev and these will overwrite the other setting.

For example:

....
"extra": {
    "magento-deploystrategy": "copy",
    "magento-deploystrategy-dev": "symlink",
}
...

+ updated projectconfig to support -dev values when deploying
  diverent strategies for dev and production can be handled
@JeroenBoersma
Copy link
Contributor Author

Fixes #162

@Flyingmana
Copy link
Contributor

thank you very much, thats a nice solution :)

A followup PR adding some documentation in the Docs (maybe the FAQ section) and maybe some tests would be appreciated.

@Flyingmana Flyingmana merged commit f65dc0c into Cotya:master Jun 6, 2017
@JeroenBoersma
Copy link
Contributor Author

If there is something I can do, just hit me up... Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants