copilot-c99: Add volatile qualifier to external stream variable
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanperez-keera
changed the title
|
@robdockins the feature to customize the output directory is already in copilot. Can you please rebase this PR wrt. develop, dropping that commit and leaving only 6de857e? No other changes are needed; if they are, I will ask. Thanks! |
ivanperez-keera
changed the title
copilot-c99: Add volatile qualifier to external stream variable
|
Will do |
representing external streams. As we expect these variables to be modifed concurrently or via interrupts, the volatile qualifier is appropriate, and prevents the compiler from performing code motion that might cause unexpected behavior. Ideally, these reads (which occur at the beginning of the step function) should also be protected by a critical section that masks interrupts or takes a mutex. Partially addresses Copilot-Language#257
robdockins
force-pushed
the
codegen-enhancements
branch
from
93b1df6 to
0c65be3
Compare
|
Rebased as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor enhancements to the code generation process. This adds volatile qualifiers to external stream global variables, and allows users to select an output directory for generated code.