Replace mpl by mp11 (part 2/2) #3983
Conversation
|
The only MPL thing missing here is |
bernhardmgruber
force-pushed
the
mp11_apply
branch
3 times, most recently
from
b0a576c
to
c16eba7
Compare
|
I have this PR on my radar and will try to rebase and test it together with #3834 soon. |
bernhardmgruber
force-pushed
the
mp11_apply
branch
from
c16eba7
to
cc57059
Compare
bernhardmgruber
force-pushed
the
mp11_apply
branch
2 times, most recently
from
eb5861b
to
91e9550
Compare
psychocoderHPC
force-pushed
the
mp11_apply
branch
from
91e9550
to
9a2a80a
Compare
include/pmacc/meta/Apply.hpp
Outdated
| { | ||
| using type = E<typename ReplacePlaceholdersImpl<Ts, Args...>::type...>; | ||
| // nested ::type of E to mimic mpl::apply | ||
| //using type = typename E<typename ReplacePlaceholdersImpl<Ts, Args...>::type...>::type; |
There was a problem hiding this comment.
@bernhardmgruber we need to activate this because I would say that we have many places where we rely on the recursive apply.
Never the less both versions currently not compile.
psychocoderHPC
force-pushed
the
mp11_apply
branch
from
9a2a80a
to
8dc2991
Compare
psychocoderHPC
added
component: PMacc
| { | ||
| using type = Free; | ||
| }; | ||
| using fn = Free; |
There was a problem hiding this comment.
Why is this called fn and not apply as in mpl?
There was a problem hiding this comment.
Because fn is mp11's terminology. See: https://www.boost.org/doc/libs/master/libs/mp11/doc/html/mp11.html:
A quoted metafunction is a class with a public metafunction member called fn, for example ...
| typename boost::mpl::apply<T_Functor, T_Params...>::type>; | ||
| }; | ||
| // template<typename... T_Params> | ||
| // using fn = Filtered<T_FilterOperator, Apply<T_Filter, T_Params...>, Apply<T_Functor, T_Params...>>; |
There was a problem hiding this comment.
I do not think that it is correct that this is removed.
The T_Filter and T_Functor must be updated with new signatures.
| @@ -36,29 +36,17 @@ namespace picongpu | |||
| * @tparam T_GetLowerMargin lower margin for pusher getter type | |||
| * @tparam T_GetUpperMargin upper margin for pusher getter type | |||
| */ | |||
| template< | |||
| typename T_Species, | |||
| typename T_GetLowerMargin = GetLowerMargin<GetPusher<boost::mpl::_1>>, | |||
There was a problem hiding this comment.
This looks wrong, the margins of the pusher will not be taken into account anymore.
bernhardmgruber
force-pushed
the
mp11_apply
branch
from
8dc2991
to
af4650d
Compare
Co-authored-by: René Widera <[email protected]>
bernhardmgruber
force-pushed
the
mp11_apply
branch
from
af4650d
to
e066555
Compare
|
Is this still planned? @psychocoderHPC @bernhardmgruber |
This is a continuation of the epic saga started in #3834. It continues by refactoring the seqence meta algorithms and replaces
boost::mpl::apply.