-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Adaptive Column Width for StaggeredLayout #371
Merged
Arlodotexe
merged 7 commits into
CommunityToolkit:main
from
Poker-sang:poker/feat/staggered-layout
Mar 25, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e89bfe7
Update StaggeredLayout.cs
Poker-sang 70aa78e
Create StaggeredLayoutItemsStretch.cs
Poker-sang a9dd330
Update StaggeredLayout.cs
Poker-sang 459faa8
Merge branch 'CommunityToolkit:main' into poker/feat/staggered-layout
Poker-sang 6d94771
Update example
Poker-sang 388f7f1
Fix wrong property
Poker-sang c1b85bd
Format
Poker-sang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
components/Primitives/src/StaggeredLayout/StaggeredLayoutItemsStretch.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
namespace CommunityToolkit.WinUI.Controls; | ||
|
||
/// <summary> | ||
/// Defines constants that specify how items are sized to fill the available space in a <see cref="StaggeredLayout"/>. | ||
/// </summary> | ||
public enum StaggeredLayoutItemsStretch | ||
{ | ||
/// <summary> | ||
/// The items' width is determined by the <see cref="StaggeredLayout.DesiredColumnWidth"/>. | ||
/// </summary> | ||
None, | ||
|
||
/// <summary> | ||
/// The items' width is determined by the parent's width. The minimum width is determined by the <see cref="StaggeredLayout.DesiredColumnWidth"/>. | ||
/// </summary> | ||
Fill | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦙 Leaving a marker here for historical record/the future that we had missed the
state.ColumnWidth
here not being the desired value ofcolumnWidth
calculated above, as@Poker-sang
called out here: #542 (comment)