Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] OpacityMaskView #491
base: main
Are you sure you want to change the base?
[Experiment] OpacityMaskView #491
Changes from 4 commits
c18f789
22fb628
3bcc44f
2041235
b267e56
ad14d18
54e0799
dc3427a
ce46c6f
dafd7fb
4d8f969
5adf13a
1decd44
73bbb47
9b2268e
9ec8111
aa4539f
f022067
fd37449
8e0da1e
38db553
c2d6602
0440794
a23366c
1965f53
2fb74f9
ce88a2b
c4b70f2
45e3a1d
966d7ef
d80eb50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to apply any of this like we do for the
AttachedCardShadow
/AttachedShadow
orUIElementExtensions.VisualFactory
components in the Toolkit, so it's just an extension that can be applied to any element directly vs. a ContentControl?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-hawker I don't think we can do this. Sergio created one like
UIElementExtensions.OpacityMask
in store, but the position of theredirectVisual
is not aligned with the source control at some times. When this happens, we use aBorder
to wrap the content to fix. I think the one in the toolkit should be more generic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds similar to what we have to do for the
AttachedDropShadow
at times. I think having specific requirements can be fine, it's just extensions are a lot easier to add into a design than having to add another layer of depth to the Visual Tree to all cases and setup the layout. It's probably a case of a templated control vs. a raw-element with the CardShadow too I'd imagine. What are your thoughts @Sergio0694?