[native] Fix cropped avatar selection

Summary:
Fixes cropping part of [[ https://linear.app/comm/issue/ENG-4053/setting-avatars-not-working-jaceks-bug-report | ENG-4053 ]].

Avoided replacing image URI with fetched asset URI when the file is in app's cache dir - this is where expo-image-picker stores cropped images.

Test Plan: Set cropped photo as an avatar - it is set correctly. Sent multimedia both with media gallery and image picker - both ways work. Checked both iOS and Android.

Reviewers: atul, ashoat, ginsu

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D8739

native/media/file-utils.js

@@ -1,6 +1,7 @@
 // @flow
 
 import base64 from 'base-64';
+import * as ExpoFileSystem from 'expo-file-system';
 import * as MediaLibrary from 'expo-media-library';
 import invariant from 'invariant';
 import { Platform } from 'react-native';
@@ -57,14 +58,14 @@ async function fetchFileInfo(
   const { mediaNativeID } = optionalInputs;
   const steps = [];
 
-  let assetInfoPromise, newLocalURI;
+  let assetInfoPromise, assetURI;
   const inputPath = pathFromURI(inputURI);
   if (mediaNativeID && (!inputPath || optionalFields.orientation)) {
     assetInfoPromise = (async () => {
       const { steps: assetInfoSteps, result: assetInfoResult } =
         await fetchAssetInfo(mediaNativeID);
       steps.push(...assetInfoSteps);
-      newLocalURI = assetInfoResult.localURI;
+      assetURI = assetInfoResult.localURI;
       return assetInfoResult;
     })();
   }
@@ -150,11 +151,18 @@ async function fetchFileInfo(
   }
 
   let finalURI = uri;
-  if (newLocalURI && newLocalURI !== uri) {
-    finalURI = newLocalURI;
+  // prefer asset URI, with one exception:
+  // if the target URI is a file in our app local cache dir, we shouldn't
+  // replace it because it was already preprocessed by either our media
+  // processing logic or cropped by expo-image-picker
+  const isFileInCacheDir =
+    uri.includes(temporaryDirectoryPath) ||
+    uri.includes(ExpoFileSystem.cacheDirectory);
+  if (assetURI && assetURI !== uri && !isFileInCacheDir) {
+    finalURI = assetURI;
     console.log(
       'fetchAssetInfo returned localURI ' +
-        `${newLocalURI} when we already had ${uri}`,
+        `${assetURI} when we already had ${uri}`,
     );
   }