Qodana #201
379 new problems found by Qodana for .NET
Qodana for .NET
379 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 85 |
Redundant using directive |
🔶 Warning | 26 |
Redundant cast |
🔶 Warning | 21 |
Expression is always 'true' or 'false' according to nullable reference types' annotations |
🔶 Warning | 18 |
Conditional access qualifier expression is not null according to nullable reference types' annotations |
🔶 Warning | 18 |
Possible 'System.NullReferenceException' |
🔶 Warning | 18 |
Remove redundant attached property setter |
🔶 Warning | 13 |
RoslynAnalyzers Project does not enable unsafe blocks |
🔶 Warning | 11 |
Redundant catch clause |
🔶 Warning | 10 |
Property value is equal to style-provided |
🔶 Warning | 10 |
Missing grid column/row setter for non-first child |
🔶 Warning | 9 |
Assignment is not used |
🔶 Warning | 8 |
Virtual member call in constructor |
🔶 Warning | 8 |
Collection content is never queried (non-private accessibility) |
🔶 Warning | 7 |
Redundant explicit type in array creation |
🔶 Warning | 7 |
Access to modified captured variable |
🔶 Warning | 6 |
Underlying type of enum is 'int' |
🔶 Warning | 6 |
Non-readonly type member referenced in 'GetHashCode()' |
🔶 Warning | 6 |
Parameter hides member |
🔶 Warning | 6 |
Redundant explicit size specification in array creation |
🔶 Warning | 6 |
Unsafe context declaration is redundant |
🔶 Warning | 6 |
Avoid mixing of variable-length escape sequences and text |
🔶 Warning | 6 |
Redundant empty switch section |
🔶 Warning | 5 |
Unused local variable |
🔶 Warning | 5 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 4 |
Redundant nullable warning suppression expression |
🔶 Warning | 4 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 4 |
Collection content is never queried (private accessibility) |
🔶 Warning | 3 |
Expression is always 'true' or always 'false' |
🔶 Warning | 3 |
Non-accessed field (private accessibility) |
🔶 Warning | 3 |
Redundant base constructor call |
🔶 Warning | 3 |
Redundant name qualifier |
🔶 Warning | 3 |
Actual shift count equals zero |
🔶 Warning | 3 |
Grid element column/row index is out of grid definition range |
🔶 Warning | 3 |
'?:' expression has identical true and false branches |
🔶 Warning | 2 |
Member initialized value ignored |
🔶 Warning | 2 |
Non-accessed local variable |
🔶 Warning | 2 |
Redundant control flow jump statement |
🔶 Warning | 2 |
Path error |
🔶 Warning | 2 |
Redundant namespace alias |
🔶 Warning | 2 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 1 |
Collection is never updated (non-private accessibility) |
🔶 Warning | 1 |
RoslynAnalyzers Class is not marked partial |
🔶 Warning | 1 |
Empty general catch clause |
🔶 Warning | 1 |
Inconsistent synchronization on field |
🔶 Warning | 1 |
Cannot resolve symbol in text argument |
🔶 Warning | 1 |
Mismatch of optional parameter value in overridden method |
🔶 Warning | 1 |
Parameter output value is always discarded (private accessibility) |
🔶 Warning | 1 |
Explicit delegate creation expression is redundant |
🔶 Warning | 1 |
Redundant member override |
🔶 Warning | 1 |
Return type of a function can be made non-nullable |
🔶 Warning | 1 |
Shift expression with zero left operand equals zero |
🔶 Warning | 1 |
Variable can be declared as non-nullable |
🔶 Warning | 1 |
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 579 in Hi3Helper.Sophon/SophonAsset.Download.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 443 in Hi3Helper.Sophon/SophonAsset.Diff.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 459 in Hi3Helper.Sophon/SophonAsset.Diff.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 453 in Hi3Helper.Sophon/SophonAsset.Diff.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 573 in Hi3Helper.Sophon/SophonAsset.Download.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 563 in Hi3Helper.Sophon/SophonAsset.Download.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 394 in CollapseLauncher/Classes/RepairManagement/StarRail/Check.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 23 in Hi3Helper.EncTool/Parser/CachePatchManifest/CachePatchManifest.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'PatchAsset' is only updated but never used
Check warning on line 20 in CollapseLauncher/Classes/Interfaces/Class/CommunityToolsProperty.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'OfficialToolsList' is only updated but never used
Check warning on line 28 in Hi3Helper.Win32/ShellLinkCOM/Win32FindDataW.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'cAlternateFileName' is only updated but never used
Check warning on line 22 in CollapseLauncher/Classes/Interfaces/Class/CommunityToolsProperty.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'CommunityToolsList' is only updated but never used
Check warning on line 22 in Hi3Helper.Win32/ShellLinkCOM/Win32FindDataW.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'cFileName' is only updated but never used
Check warning on line 29 in InnoSetupHelper/InnoSetupLogParser/Parser.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'ReservedHeaderBytes' is only updated but never used
Check warning on line 146 in Hi3Helper.EncTool/Parser/XMFParser/Class/XMFBlock.cs
github-actions / Qodana for .NET
Collection content is never queried (non-private accessibility)
Content of collection 'UniqueID' is only updated but never used
Check warning on line 136 in Hi3Helper.EncTool/Parser/AssetIndex/AssetIndexV2.cs
github-actions / Qodana for .NET
Collection content is never queried (private accessibility)
Content of collection 'strBuffer' is only updated but never used
Check warning on line 158 in Hi3Helper.EncTool/Parser/BlockPatchManifest/BlockPatchManifest.cs
github-actions / Qodana for .NET
Collection content is never queried (private accessibility)
Content of collection 'versionArrayNum' is only updated but never used
Check warning on line 39 in CollapseLauncher/XAMLs/MainApp/Pages/OOBE/OOBEAgreementMenu.xaml.cs
github-actions / Qodana for .NET
Collection content is never queried (private accessibility)
Content of collection 'markdownFileList' is only updated but never used
Check warning on line 17 in Hi3Helper.Win32/ToastCOM/Notification/ToastComboBox.cs
github-actions / Qodana for .NET
Collection is never updated (non-private accessibility)
Content of collection 'Selection' is never updated
Check warning on line 178 in Hi3Helper.Sophon/SophonUpdate.cs
github-actions / Qodana for .NET
Expression is always 'true' or always 'false'
Expression is always true
Check warning on line 136 in Hi3Helper.Core/Classes/Data/Tools/SteamTool.cs
github-actions / Qodana for .NET
Expression is always 'true' or always 'false'
Expression is always true
Check warning on line 121 in CollapseLauncher/Classes/RepairManagement/Honkai/HonkaiRepair.cs
github-actions / Qodana for .NET
Expression is always 'true' or always 'false'
Expression is always true
Check warning on line 134 in Hi3Helper.Http/Legacy/Session/SessionTask.cs
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations
Check warning on line 286 in Hi3Helper.Http/Legacy/Session/Session.cs
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations
github-actions / Qodana for .NET
Expression is always 'true' or 'false' according to nullable reference types' annotations
Expression is always true according to nullable reference types' annotations