Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some locales #29

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2024

i speak chinese, i only know a little english and japanese so sorry if this introduce more issue

@ghost
Copy link
Author

ghost commented Mar 17, 2024

sorry for pinging, @reindex-ot @igormiguell @keldrion maybe look into this for once...

btw, t25 is about whether to create a multipurpose rom package (as it writes 卡线一体 in chinese, which means support both flashing on PC, and flashing directly on device, like via TWRP or sth)

@ghost
Copy link
Author

ghost commented Mar 17, 2024

by looking at the source code, warn6 seems to be related to the previously extracted image files from the logo partition, so it probably mean the extracted logo pictures

warn8 is trying to say the plugin doesn't have an entrypoint (main.sh or msh), so it simply cannot be executed

also warn14 seems to be talking about the GUI support in plugins, and this msg is printed when the type of the gui component has an unexpected value

text35 is probably trying to say the dependency is found, instead of missing (like in text36)

text56 is about the name of main dynamic partition group in the super partition, this can be found in android documentation on google

text69 means "an exception was thrown"

text101 was wrong probably because '主题' can mean both topic and theme in chinese (so some translator will mess it up??)

t31 actually means "the way to handle the image size" in the original chinese text

@ghost
Copy link
Author

ghost commented Mar 17, 2024

i didn't verify everything carefully, so maybe i have some major mistakes here as well, but i can try to help with the chinese part, so maybe we can move this to a discussion under this repo if necessary (?

@ghost ghost requested a review from ColdWindScholar March 18, 2024 12:16
@ghost ghost marked this pull request as draft March 18, 2024 13:14
@ghost ghost force-pushed the main branch 6 times, most recently from 0ad8c50 to 1b69af4 Compare March 19, 2024 11:31
@compooser

This comment was marked as off-topic.

@ghost

This comment was marked as off-topic.

@ghost ghost force-pushed the main branch 2 times, most recently from 9ca1db2 to 5ee5d60 Compare March 23, 2024 04:56
@ghost ghost changed the title Attempt to fix up some the mistakes in english and other affected locales Fix up some locales Mar 23, 2024
@ghost ghost marked this pull request as ready for review March 23, 2024 04:59
@ghost ghost force-pushed the main branch 3 times, most recently from ea24bee to 7bf82a8 Compare March 23, 2024 05:05
Signed-off-by: Ookiineko <[email protected]>
@ColdWindScholar ColdWindScholar merged commit 38296cf into ColdWindScholar:main Mar 23, 2024
1 of 4 checks passed
@ghost
Copy link
Author

ghost commented Mar 24, 2024

see also : #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants