Fix Flask issue when loading "escape" from Jinja2 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltzmax
reviewed
Jun 27, 2022
There was a problem hiding this comment.
Hello.
I believe you didn't test this 100%?
This didn't really solve the issue after several testing today. but bumping flask to 2.1.0 fixed it since flask V1.X.X uses the escape module from Jinja, and what i found out over my testing and googling into release notes was however recently support for the escape module was dropped in newer versions of Jinja which means that jinja version 3.1.0 seems to be needing flask version 2.1.0 to work, since that's the only version i got jinja 3.1.0 to work with.
Solution other than bumping versions
Bumping versions is indeed the easist way, you can also import from markupsafe import escape to fix the issue as well. It's stated in jinja's release notes.
TheRazvy
approved these changes
Sep 18, 2022
|
somewhat duplicate of #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Bug Fix
Description of the changes
As described in #71 Flask is currently trying to import 'escape' from Jinja2, which removed the escape function in 3.1.0 (released March 24, 2022).
This Pull Request locks Jinja2 to pre-3.1.0 versions to prevent this issue, and adds werkzeug 2.0.3 which is required by older versions of Jinja2.