Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging / Release Action #94

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Packaging / Release Action #94

merged 2 commits into from
Dec 5, 2023

Conversation

thinkl33t
Copy link
Contributor

@thinkl33t thinkl33t commented May 2, 2023

  • Automatically push to pypi testing on push-to-main
  • Automatically push to pypi on tag

Closes: #95

Pushes to test pypi every push
Pushes to real pypi if tagged
@thinkl33t thinkl33t changed the title DRAFT: Packaging / Release Action Packaging / Release Action Dec 5, 2023
Copy link
Contributor

@jonathanmaw jonathanmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look logical and line up with the documentation.
The test run looks like it's doing exactly what it's expected to.

I have as much certainty that this is doing exactly what is expected as is possible without actually trying to upload to the non-testing pypi.
Approved!

@thinkl33t thinkl33t merged commit 05b78a1 into main Dec 5, 2023
7 checks passed
@thinkl33t thinkl33t deleted the bobclough/packaging-push branch December 5, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI should deploy to pypi
2 participants