Several project view adjustments in CSS #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </span> | ||
| <% } %> | ||
| <% if (story.get('story_type') == 'chore') { %> | ||
| <i class="fa fa-cog"></i> |
…heir icons All adapter from the latest commits of this other fork: https://github.com/hakunin/fulcrum/commits/feature/classic-design
akitaonrails
force-pushed
the
visual_adjustments
branch
from
54be505
to
3a8f8bb
Compare
| padding-right: 2px; | ||
| top: -3px; | ||
| background: transparent; | ||
| line-height: 15px; |
There was a problem hiding this comment.
.estimates {
padding-left: 10px;
padding-right: 2px;
.estimate {
font-weight: normal;
border-radius: none;
margin-left: -3px;
border-right: 1px solid #858484;
padding-right: 2px;
top: -3px;
background: transparent;
line-height: 15px;
}
}
akitaonrails
force-pushed
the
visual_adjustments
branch
from
3a8f8bb
to
e7876a5
Compare
adbatista
force-pushed
the
visual_adjustments
branch
from
1295fcb
to
cd6556d
Compare
Copied and adapted from here: https://github.com/BlackrockDigital/startbootstrap-simple-sidebar TODO: instead of the sidebar pushing the content to the right, it should be an overlay on top of the content
| padding-right: 2px; | ||
| top: -3px; | ||
| background: transparent; | ||
| line-height: 15px; |
There was a problem hiding this comment.
It's a good practice not to use units when defining a value for the line-height property, it can lead to unexpected behavior with child elements (although I think won't be the case here).
…he left and transitions by resizing the content container. Instead the sidebar is a fixed layer on top of the content but hidden and the toggle makes it visible. Moving most of the main menu and also the project view’s column toggle buttons as links in the same sidebar. And making the mobile view show just the in_progress column and making a few adjustments so it just renders barely correct.
…ing a new note is not return as soon as the server finishes and the refresh is being used to update the view state. Must investigate. For now, tuning the timeout down to pick up the updates faster (less than 10 seconds)
Adjusting CSS to have better spacing between elements
|
@vitortalaia @adbatista @rscardinho I've just pushed a bunch of CSS and JS adjustments to make it all work reasonably good in mobile view. Check out the updated PR description above. Feedback is greatly appreciated! |
|
Using |
…e icons so the specs don’t get ambiguous selectors.
Adjusting the buttons for the velocity override
| @@ -626,6 +623,11 @@ div#keycut-help { | |||
| .sign-in .checkbox { | |||
| margin-left: 50px; | |||
| } | |||
| .devise_links { | |||
There was a problem hiding this comment.
We should use devise-links here instead of devise_links to follow the standard of the other class names.
Make the scale to view port only show one column when in a mobile view Make add story open the chilly bin column if hidden Make the view has at least the in progress column open if all are hidden
Velocity can’t be zero
akitaonrails
force-pushed
the
visual_adjustments
branch
from
11a9b91
to
800e3f8
Compare
akitaonrails
force-pushed
the
visual_adjustments
branch
from
800e3f8
to
18d5fd6
Compare
Making the devise links be a proper list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All adapter from the latest commits of this other fork: fulcrum-agile/fulcrum#251
cc @viniciuspalma @talyssonoc