Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] C# Strings: .Format() #5609

Merged

Conversation

dgiansante
Copy link
Contributor

@dgiansante dgiansante commented Nov 8, 2024

Description

Added the String.Format() term for C#.

This entry is lengthy due to the sections on format specifiers. However, format specifiers are also used in interpolated strings and other methods (e.g., the .ToString() method of numeric, date, and enum classes). I believe this information deserves its own page. However, I’ve included it here for now, as formatting numeric and date values is commonly done with this method, and omitting this detail would be a missed opportunity. As this is my first contribution, I'm unsure how to proceed and will wait for your feedback.

Issue Solved

Closes issue #5565.

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@PragatiVerma18 PragatiVerma18 self-assigned this Nov 9, 2024
@PragatiVerma18 PragatiVerma18 added the status: under review Issue or PR is currently being reviewed label Nov 9, 2024
@PragatiVerma18 PragatiVerma18 added status: waiting for author docs Docs community entries c# C# entries status: review 1️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 9, 2024
@dgiansante dgiansante force-pushed the issue-5565-csharp-string-format branch from 0c41f9a to 7c8e18f Compare November 10, 2024 14:10
@dgiansante
Copy link
Contributor Author

Hi @PragatiVerma18 ,
I've made and pushed the changes you suggested.
In line with your suggestions, I've also worked to further clarify certain sections that might be challenging for beginners, especially in the part on format specifiers for enum values.

Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dgiansante, these changes look good to me. I am marking it for the second review. Thanks for the contribution!

fixed minor punctuation errors.
@Radhika-okhade
Copy link
Collaborator

Hey! @dgiansante, The entry looks good. I just have one suggestion. The content is too big for a term entry. I have specified the part that needs to be removed.

@Radhika-okhade Radhika-okhade added status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Nov 13, 2024
@dgiansante
Copy link
Contributor Author

Hey @Radhika-okhade, I've made the changes you suggested.

@Radhika-okhade
Copy link
Collaborator

Thank you @dgiansante

Copy link
Collaborator

@Radhika-okhade Radhika-okhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy docs. The entry looks good to be merged.

@Radhika-okhade Radhika-okhade merged commit 067b7f1 into Codecademy:main Nov 15, 2024
6 checks passed
Copy link

👋 @dgiansante
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/c-sharp/strings/format

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants