Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of cat.md for pytorch #5405

Merged
merged 18 commits into from
Nov 15, 2024
Merged

Conversation

arisdelacruz
Copy link
Contributor

Description

This is an attempt to create the .cat() entry for PyTorch. This aims to provide additional information to the body of knowledge on the topic.

Issue Solved

Closes #5350

Type of Change

  • Adding a new entry

Checklist

  • [/] All writings are my own.
  • [/] My entry follows the Codecademy Docs style guide.
  • [/] My changes generate no new warnings.
  • [/] I have performed a self-review of my own writing and code.
  • [/] I have checked my entry and corrected any misspellings.
  • [/] I have made corresponding changes to the documentation if needed.
  • [/] I have confirmed my changes are not being pushed from my forked main branch.
  • [/] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [/] I have linked any issues that are relevant to this PR in the Issues Solved section.

@arisdelacruz
Copy link
Contributor Author

@mamtawardhani

I think I got it right. Thanks

@mamtawardhani mamtawardhani self-assigned this Oct 5, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed pytorch PyTorch labels Oct 5, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arisdelacruz thank you for contributing to Codecademy Docs! The entry is very well written! 😄

I've suggested some minor changes, could you please review and modify those at your earliest convenience? Thank you! 😃

content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/cat/cat.md Outdated Show resolved Hide resolved
@arisdelacruz
Copy link
Contributor Author

done, @mamtawardhani

thanks

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the modifications @arisdelacruz 😄

The entry looks good for a second round of review 🚀

@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Oct 7, 2024
@avdhoottt avdhoottt self-assigned this Oct 7, 2024
Copy link
Collaborator

@Radhika-okhade Radhika-okhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy docs. The entry looks good to be merged.

@Radhika-okhade Radhika-okhade merged commit c32d379 into Codecademy:main Nov 15, 2024
6 checks passed
Copy link

👋 @arisdelacruz
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pytorch/tensors/cat

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Radhika-okhade Radhika-okhade added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] PyTorch Tensors .cat()
4 participants