Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image flag fixes and code consolidation #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Unrealomega
Copy link

What's changed:

  • Consolidated both plugin files into a single plugin for sanity sake, reducing any development overhead as both plugins did roughly the same thing.
  • Added image flags to .tpsheet and .tpset. Now pixel art won't look muddled.
  • Removed some excess code and added a bit more error checking.

Known Issues:

  • Using Godot 3.2, the below error appears when importing:
* core/os/file_access.cpp:667 - Condition "!f" is true. Continuing.
* Cannot open file 'res://.import/filename.tpset-b0fde670dee72c7687aa825efad333a9.res'. # Only does this for Spritesheets

This does not appear to be related to the plugin, but I can't fully confirm this as I've been unable to nail down what is causing the issue (it doesn't occur when the plugin is installed).

  • Using Godot 3.2, every time you alt-tab in and out, it auto-imports. Though the impact is small, it halts development for at least a few seconds and may have some impact on the hardware long-term (reads and write). This issue has existed before this update, at least with my machine.

Unrealomega added 5 commits September 14, 2020 02:16
* Bump the version to 1.0.6
* Added Pixel Art preset to deal with filter settings that cause certain tileset/spritesheet to become blurry.
* Removed an unused code that creates a spritesheet folder when importing a tileset.
* Consolidated the packer into one file as a lot of it's functions are similar. Only issue I can find is that the options don't seem to apply to existing spritesheets .tres files, which may be because it's not recreating them each time.
* Removed the extra ResourceSaver in Spritesheet's code, looks like it was a holdover from the tiled code.
Fixed bug that was preventing presets on Spritesheets from working properly.
Made some small changes that are purely for readability. Also removed some debug stuff.
@Unrealomega Unrealomega changed the title Image flag fixes Image flag fixes and code consolidation Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant