-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event follow and RSVP #38
Open
kitkatdafu
wants to merge
55
commits into
dev
Choose a base branch
from
event-follow-save
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add status flag, EventStatus
display cancelled events' title strikethroughed
fix typo
add a new db operation, changeEventStatusCodeById, which changes event's status to a given status code.
add a new api, changeEventStatus, which updates event's status to a given status code
fix typo
create a new file with a function that helps to display confirmation box
fix typo
use show_modal() to display the confirmation box
add logistics for cancel/uncancell event
move moda/confirmation box to a global scope (inside head.ejs)
include modal.js
move modal/confirmation box from event
not sure if this should be changed. When I am testing email service, with path = /app/.., file not exists error was thrown.
jialuogao
requested changes
Nov 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to see majority of your pages, please fix those issues I found and let me know then I'll take a look later
add a new api for checking if user has profile
add an if statement to check db error
add a guard to check if user has profile.
fix the msg issue
revert back
klmui
previously approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can follow events and receive an email of the event.
Followed events can be seen together in a list view,
/event/followed.ejs
.An email is going to send to the user's email if the
RSVP
button is clicked.I have modified the
notification-bar
a bit. Allowing it to display customized failure/success message. Also, when success, thebackground-color
of thenotification-bar
is green, whereas when failure, thebackground-color
is red.