Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polychord 1.20.0 #232

Merged

Conversation

williamjameshandley
Copy link
Contributor

This branch aligns cobaya with the latest version of polychord (1.20.0), as well as instantiating some functionality which was present in 1.18.2 (e.g. variable nlive, nprior and maximisation).

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #232 (b9e479d) into master (1fdbb58) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   87.53%   87.55%   +0.01%     
==========================================
  Files          92       92              
  Lines        8057     8057              
==========================================
+ Hits         7053     7054       +1     
+ Misses       1004     1003       -1     
Impacted Files Coverage Δ
cobaya/samplers/polychord/polychord.py 31.74% <33.33%> (ø)
cobaya/samplers/mcmc/mcmc.py 90.47% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fdbb58...b9e479d. Read the comment docs.

@JesusTorrado JesusTorrado changed the base branch from master to install_check_version March 5, 2022 16:41
@JesusTorrado JesusTorrado merged commit 2685e0c into CobayaSampler:install_check_version Mar 5, 2022
@JesusTorrado
Copy link
Contributor

@williamjameshandley Any chance of a minor release in the next few days, including the __version__ variable that had not been added yet for the v1.20 tag?

It would be quite useful: with the new PR #237 users would get a warning at runtime that they need to install the new PolyChord version (they will have 1.18.2 installed at that point). Otherwise they'll get a non-descriptive error after they update Cobaya, if they haven't run cobaya-install.

@williamjameshandley
Copy link
Contributor Author

Any possibility we could work #233 and #231 into the next cobaya release? I have tested them quite thoroughly locally. In particular cobaya does not work out-of-the-box without #231

@williamjameshandley
Copy link
Contributor Author

I've now created a 1.20.1 release (the version number in cobaya/samplers/polychord/polychord.py will need to be updated)

@JesusTorrado
Copy link
Contributor

Thanks!

#231 for sure. #233 in the next minor (I need to think about being able to use the external priors as such).

JesusTorrado pushed a commit that referenced this pull request May 7, 2022
* Updated for PolyChord 1.20.0

* added missing nfail

* Updated version number

* Fixed flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants