Support macOS 10.14 Mojave for x86_64 deployment #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace powershell Invoke-WebRequest by curl.
djova-dolby
force-pushed
the
support-macOS-Mojave
branch
3 times, most recently
from
a91a96b
to
900e95a
Compare
djova-dolby
approved these changes
Mar 25, 2024
- Windows runner has cmake 3.28 - It is not detecting properly escaped quotes around x64 arch - Harcode it to make sure it works
- Lets see if this fixes the windows build
- This will autocancel new workflows if same branch is pushed with new/ammended commits
- This is workaround - Download and use cmake 3.21 on Windows - Elleviate these issues with 3.28 on these new windows machines - Like not finding ffmpeg
- This will be using x64 machines, but Xcode lets you cross-compile for both archs - For webrtc/native-sdks we build everything on x64 machines - I am not sure though if some of these deps installed or whatever except to be on arm64 system - Like how OBS build is configured and such and going into this would be waste of time now - Thus if this doesn't work we will just fix the self hosted machine and thats it
- We now use cmake 3.21 which should fix this This reverts commit a179e45.
djova-dolby
force-pushed
the
support-macOS-Mojave
branch
from
6379f1f
to
a9f14aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.