Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the test delays as they were before #277

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Increase the test delays as they were before #277

merged 1 commit into from
Apr 23, 2024

Conversation

badboywj
Copy link
Contributor

@badboywj badboywj commented Apr 19, 2024

The issue happened on 12-SP5 after updating the sleep time from the current master branch(commit: 1219b4b) in ClusterLabs
https://openqa.suse.de/tests/14048367#step/hawk_gui/82

and everything worked well after changing the sleep time back.

Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksei-burlakov
Copy link
Contributor

The word revoke is somewhat misleading without the context. If you look the git log, you will see that all previous commits have explanations. Could you please write it more explicitly, and more verbose like

Increase the test delays back, as they were before

The issue happened on <the upstream version XYZ> after updating the sleep time from the current master branch in ClusterLabs
https://openqa.suse.de/tests/14048367#step/hawk_gui/82

and everything worked well after changing the sleep time back.

@badboywj badboywj changed the title Revoke sleep time Adjust sleep time Apr 22, 2024
@badboywj badboywj changed the title Adjust sleep time Increase the test delays Apr 22, 2024
@badboywj badboywj changed the title Increase the test delays Increase the test delays as they were before Apr 22, 2024
@badboywj
Copy link
Contributor Author

The word revoke is somewhat misleading without the context. If you look the git log, you will see that all previous commits have explanations. Could you please write it more explicitly, and more verbose like

Increase the test delays back, as they were before

The issue happened on <the upstream version XYZ> after updating the sleep time from the current master branch in ClusterLabs
https://openqa.suse.de/tests/14048367#step/hawk_gui/82

and everything worked well after changing the sleep time back.

Good suggestion, I have updated the PR title and description, thank you 👍

@alvarocarvajald
Copy link
Contributor

The word revoke is somewhat misleading without the context. If you look the git log, you will see that all previous commits have explanations. Could you please write it more explicitly, and more verbose like

Increase the test delays back, as they were before

The issue happened on <the upstream version XYZ> after updating the sleep time from the current master branch in ClusterLabs
https://openqa.suse.de/tests/14048367#step/hawk_gui/82

and everything worked well after changing the sleep time back.

Good suggestion, I have updated the PR title and description, thank you 👍

I think @aleksei-burlakov meant to also change the commit message, as that's what is left in the repository log.

The issue happened on 12-SP5 after updating the sleep time from the
current master branch(commit: 1219b4b) in ClusterLabs
https://openqa.suse.de/tests/14048367#step/hawk_gui/82

and everything worked well after changing the sleep time back.
@aleksei-burlakov
Copy link
Contributor

The word revoke is somewhat misleading without the context. If you look the git log, you will see that all previous commits have explanations. Could you please write it more explicitly, and more verbose like

Increase the test delays back, as they were before

The issue happened on <the upstream version XYZ> after updating the sleep time from the current master branch in ClusterLabs
https://openqa.suse.de/tests/14048367#step/hawk_gui/82

and everything worked well after changing the sleep time back.

Good suggestion, I have updated the PR title and description, thank you 👍

I think @aleksei-burlakov meant to also change the commit message, as that's what is left in the repository log.

Thats right. It will make navigating through the log history easier.

@badboywj
Copy link
Contributor Author

I think @aleksei-burlakov meant to also change the commit message, as that's what is left in the repository log.

Thats right. It will make navigating through the log history easier.

I have updated commit message, please check it 😄

@aleksei-burlakov aleksei-burlakov merged commit a2f9bc8 into ClusterLabs:master Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants