Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imporovements: Multi-Filter handling #1086

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

iABn0rma1
Copy link
Contributor

@iABn0rma1 iABn0rma1 commented May 31, 2024

Description

This update optimises the working of Steam scraper by combining the filtering steps, and introducing error handling. This fixes issues where you might get repeated or undesirable results.

Resolves: [ #1006 ]

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

  • Added _construct_filter_url to scrape multiple filters at once
    Screenshot 2024-05-31 at 2 49 47 AM

  • Updated the results tags as there weren't any listings that matched both 'F2P' and 'Discounts'

image
  • Tested for 500 games with Discounts, Games and Windows, MacOS tags
image

Additional Notes/Comments

Any additional remarks or suggestions concerning this pull request are welcome.


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

@nikhil25803 nikhil25803 merged commit ffa200c into Clueless-Community:main Jun 1, 2024
@nikhil25803
Copy link
Member

Great work @iABn0rma1 !!
Do not forget to

  • Share your contribution on socials and tag Clueless 🫂
  • Give this repository a star ✨
  • Follow Clueless Community on GitHub ✅

@nikhil25803 nikhil25803 added level2 gssoc GSSoC 2024 labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC 2024 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants