-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify for the simple, instead of replacing scheduleDelayedTask. #9
Open
jrodr10
wants to merge
12
commits into
CloudburstMC:master
Choose a base branch
from
jrodr10:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We replaced the deprecated task scheduling method with NukkitRunnable. The task is scheduled using NukkitRunnable.runTaskLater(), which is better supported and cleaner. Global Plugin Access: The globally accessible Plugin instance is fetched using FakeInventoriesPlugin.getInstance() to ensure that the task is tied to the correct plugin lifecycle.
jrodr10
changed the title
Replaced scheduleDelayedTask():
Simplify for the simple, instead of replacing scheduleDelayedTask.
Sep 10, 2024
jrodr10
commented
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better?
#7 added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the deprecated task scheduling method with NukkitRunnable.
The task is scheduled using NukkitRunnable.runTaskLater(), which is better supported and cleaner.
Global Plugin Access:
The globally accessible Plugin instance is fetched using FakeInventoriesPlugin.getInstance() to ensure that the task is tied to the correct plugin lifecycle.
Also version bump though this wont break anything.