Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify for the simple, instead of replacing scheduleDelayedTask. #9

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

jrodr10
Copy link
Contributor

@jrodr10 jrodr10 commented Sep 8, 2024

I replaced the deprecated task scheduling method with NukkitRunnable.
The task is scheduled using NukkitRunnable.runTaskLater(), which is better supported and cleaner.

Global Plugin Access:
The globally accessible Plugin instance is fetched using FakeInventoriesPlugin.getInstance() to ensure that the task is tied to the correct plugin lifecycle.

Also version bump though this wont break anything.

lukeeey and others added 5 commits October 13, 2020 16:10
We replaced the deprecated task scheduling method with NukkitRunnable.
The task is scheduled using NukkitRunnable.runTaskLater(), which is better supported and cleaner.
Global Plugin Access:

The globally accessible Plugin instance is fetched using FakeInventoriesPlugin.getInstance() to ensure that the task is tied to the correct plugin lifecycle.
@jrodr10 jrodr10 changed the title Replaced scheduleDelayedTask(): Simplify for the simple, instead of replacing scheduleDelayedTask. Sep 10, 2024
Copy link
Contributor Author

@jrodr10 jrodr10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

@jrodr10
Copy link
Contributor Author

jrodr10 commented Sep 10, 2024

#7 added

@jrodr10
Copy link
Contributor Author

jrodr10 commented Sep 10, 2024

Added peterim1 fixes #11 #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants