otus-04 hw #1
Closed
otus-04 hw #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivana-
reviewed
Nov 21, 2024
| (defn next-coords | ||
| [next-index-col next-index-row {:keys [col row]}] | ||
| {:row (next-index-row row) | ||
| :col (next-index-col col)}) |
There was a problem hiding this comment.
Вопрос вкуса, можно еще (-> m (update :row next-index-row) (update :col next-index-col))
| [item n] | ||
| (->> item | ||
| (repeat n) | ||
| (vec))) |
| (defn reducer [acc val] | ||
| (if (acc val) | ||
| (update acc val inc) | ||
| (assoc acc val 1))) |
There was a problem hiding this comment.
Откройте для себя fnil : (update acc val (fnil inc 0))
|
|
||
| (defn word->map | ||
| [word] | ||
| (reduce reducer {} word)) |
| word-map (word->map word) | ||
| word-map-keys (keys word-map)] | ||
|
|
||
| (reduce #(if (< (letters-map %2 0) (word-map %2 0)) (not %1) %1) true word-map-keys))) |
There was a problem hiding this comment.
Откройте для себя merge-with Итого весь код решения
(defn scramble? [letters word]
(every? (comp not pos? second)
(merge-with -
(frequencies word)
(frequencies (filter (set word) letters)))))
| new-row (assoc square-row col square-val)] | ||
|
|
||
| (assoc acc row new-row))) | ||
| empty-vec (keys square-map)))) |
There was a problem hiding this comment.
Хорошо, но многословно. Сравните, для примера, с вариантом
(defn magic-square [n]
(let [sq (->> 0 (repeat n) vec (repeat n) vec)
move (fn [sq [r c]]
(let [norm (fn [x] (cond (< x 0) (dec n) (>= x n) 0 :else x))
rc' [(-> r dec norm) (-> c inc norm)]]
(if (zero? (get-in sq rc'))
rc'
[(-> r inc norm) c])))
rc-start [0 (quot n 2)]]
(loop [rc rc-start
[i & is] (range 2 (inc (* n n)))
sq (assoc-in sq rc-start 1)]
(if-not i
sq
(let [rc' (move sq rc)]
(recur rc' is (assoc-in sq rc' i)))))))
|
|
||
| ;; Logic | ||
| (defn- get-idx [i] | ||
| (Math/floor (/ i alphabet-size))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.