fix error in _findpolymin #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function did not actually minimize the polynomial! Our arguments do not have a 1st coefficient. This is a problem for line 47, as np.polyval assumes your coefficients include a 0th order term. This causes misidentification of tstar. We should make sure this isn't also happening in prior work.
|
this isn't quite ready. doing more testing. please don't merge! |
|
this should now be good to go. the documentation has been clarified and the minimize package passes a wide range of tests. |
|
For review, probably easiest to look at all the changes together up to the HISTORY modification, then to examine commits from then on as diffs, as the flake8 commit made small formatting changes throughout the repo (sorry - should have been a separate PR) |
|
Also - this is a pretty big deal - we should probably bump patch before merging |
jgerardsimcock
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 impax tests docsFunction did not actually minimize the polynomial!
Our arguments do not have a 1st coefficient. This is a problem for line 47, as np.polyval assumes your coefficients include a 0th order term.
This causes misidentification of tstar. We should make sure this isn't also happening in prior work.