Bug fixes and cleanup to pass flake8 in CI #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got automated tests up and running in CI with PR #35. Once it started to run
flake8
immediately flagged climate_toolbox code for a number of reasons. This PR resolves those issues.flake8
configuration tosetup.cfg
so we focus on big and immediate problems.black
. This isn't required right now, but it's the fastest way to get minor formatting fixes so the code passes theflake8
check in CI.climate_toolbox/utils/utils.py
.climate_toolbox/io/io.py
andtests/test_climate_toolbox.py
.tests/test_climate_toolbox.py
.load_bcsd()
fromclimate_toolbox/io/io.py
.With these changes,
flake8
passes the code on my local machine.