Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print more cleanly #971

Merged
merged 3 commits into from
Sep 27, 2024
Merged

print more cleanly #971

merged 3 commits into from
Sep 27, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Sep 27, 2024 •
edited
Loading

Purpose

closes #963

Disable non-root logging instead of checking if root every time we log something

Content

  • add disable_logging call to comms context init function
  • remove redundant ClimaComms.init calls
  • remove now-unused comms_ctx argument from show_memory_usage
  • check output of MPI experiments

@juliasloan25 juliasloan25 changed the title clean up iamroot usage print more cleanly Sep 27, 2024
@juliasloan25 juliasloan25 removed the request for review from charleskawczynski September 27, 2024 22:59
@juliasloan25 juliasloan25 merged commit b0ca47c into main Sep 27, 2024
7 of 8 checks passed
@juliasloan25 juliasloan25 deleted the js/prints branch September 27, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print on root more cleanly
2 participants
@juliasloan25 @Sbozzolo