Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify package imports #729

Merged
merged 1 commit into from
Apr 12, 2024
Merged

unify package imports #729

merged 1 commit into from
Apr 12, 2024

Conversation

juliasloan25
Copy link
Member

Purpose

closes #670
See issue for convention

@juliasloan25 juliasloan25 force-pushed the js/imports branch 2 times, most recently from 941e567 to 45eb539 Compare April 5, 2024 23:59
LenkaNovak
LenkaNovak reviewed Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @juliasloan25 , thank you. Just a minor suggestion to be consistent with ClimaAtmos.

experiments/AMIP/components/atmosphere/climaatmos.jl Outdated Show resolved Hide resolved
@juliasloan25 juliasloan25 force-pushed the js/imports branch 5 times, most recently from 3838572 to 6c81b77 Compare April 9, 2024 23:47
@juliasloan25 juliasloan25 requested a review from LenkaNovak April 9, 2024 23:48
LenkaNovak
LenkaNovak approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this huge effort and a therapeutic PR, @juliasloan25 ! I had a few suggestions, and a question regarding ClimaCore abbreviations, but if it's any more than a search and replace issue, then don't worry about sinking time into it. It already looks great! After the CI passes, feel free to merge.

experiments/AMIP/components/atmosphere/climaatmos.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/ocean/eisenman_seaice.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/ocean/eisenman_seaice.jl Show resolved Hide resolved
experiments/AMIP/components/ocean/prescr_seaice.jl Show resolved Hide resolved
experiments/AMIP/components/ocean/prescr_seaice.jl Outdated Show resolved Hide resolved
perf/flame_diff.jl Outdated Show resolved Hide resolved
src/Regridder.jl Outdated Show resolved Hide resolved
test/flux_calculator_tests.jl Outdated Show resolved Hide resolved
test/mpi_tests/bcreader_mpi_tests.jl Outdated Show resolved Hide resolved
test/regridder_tests.jl Outdated Show resolved Hide resolved
@LenkaNovak
Copy link
Collaborator

I also wonder if we could make the convention more visible? E.g. in the docs or in our wiki.

@juliasloan25
Copy link
Member Author

I also wonder if we could make the convention more visible? E.g. in the docs or in our wiki.

Good point! I updated the Coupler Convention part of the repo: https://github.com/CliMA/ClimaCoupler.jl/wiki/Coupler-Conventions#package-import-convention

@juliasloan25 juliasloan25 force-pushed the js/imports branch 2 times, most recently from a707187 to ebb4939 Compare April 10, 2024 21:45
@juliasloan25 juliasloan25 enabled auto-merge April 10, 2024 21:45
@juliasloan25 juliasloan25 force-pushed the js/imports branch 8 times, most recently from 0dbaaf2 to 2987fbe Compare April 12, 2024 17:51
@juliasloan25 juliasloan25 merged commit 5e22e8b into main Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

more systematic import of packages
2 participants
@juliasloan25 @LenkaNovak