move SurfaceStub to its own file #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/stub
branch
6 times, most recently
from
9162bcf to
10e9be4
Compare
LenkaNovak
approved these changes
Apr 3, 2024
LenkaNovak
approved these changes
Apr 3, 2024
juliasloan25
force-pushed
the
js/stub
branch
2 times, most recently
from
e19373d to
b610010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #669
To-do
src/Interfacertosrc/surface_stub.jlsrc/FieldExchangerandsrc/FluxCalculatortosrc/surface_stub.jlQuestions
src/Interfacer/that containssurface_stub.jlandInterfacer.jl. On one hand, this might be nicer to organizesrc/and make it clear which modulesurface_stub.jlbelongs to. On the other hand, it could be nice to maintain the flat structure we currently have insrc/.