Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep updates (Atmos v0.19.2, LSM v0.6.0) #570

Merged
merged 2 commits into from
Jan 23, 2024
Merged

dep updates (Atmos v0.19.2, LSM v0.6.0) #570

merged 2 commits into from
Jan 23, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Jan 22, 2024

Purpose

update to ClimaAtmos v0.19.2, ClimaLSM v0.6.0

replaces #566

To-do

  • update dependencies
  • change bucket precip sign for new convention in Sign convention on precip and melt flux ClimaLand.jl#445:
    • Conform to agreed upon convention that fluxes are positive if towards atmos and negative if towards ground.
      Therefore, precipitation should be negative and snow melt should be negative (corresponds to an increase in the energy of snow, or a negative heat flux).

@LenkaNovak LenkaNovak mentioned this pull request Jan 22, 2024
6 tasks
LenkaNovak added a commit that referenced this pull request Jan 23, 2024
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it looks like we're getting slabplanet non-conservation (e.g. see default slabplanet in Buildkite). This is persisting since #556. Just trying to figure out what's changed.

LenkaNovak added a commit that referenced this pull request Jan 23, 2024
@LenkaNovak
Copy link
Collaborator

Running the interactive_debug seems to be conservative, which points to the current Buildkite tests being unstable (but not blowing up yet). I can fix this as part of #568

@LenkaNovak LenkaNovak self-requested a review January 23, 2024 01:37
@juliasloan25 juliasloan25 merged commit 8aa2ba0 into main Jan 23, 2024
9 checks passed
LenkaNovak added a commit that referenced this pull request Jan 24, 2024
revert test for #570

revert test for #570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants