Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize callbacks #483

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Generalize callbacks #483

merged 1 commit into from
Nov 3, 2023

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Oct 31, 2023 •
edited
Loading

Purpose

Closes #482

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak marked this pull request as ready for review November 1, 2023 00:11
akshaysridhar
akshaysridhar approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Suggest adding the DocStringExtensions Fields information to the new structs so that they'll be captured in the API docbuild. I'm not sure what the solution to this windows-ci issue is (please also squash commits) .

@LenkaNovak
init in TimeManager + uni tests
c69e907 
implement in driver

add docs

fix tests

add CA LD path

add hourly checkpoints to pipeline

revs
@LenkaNovak
Copy link
Collaborator Author

bors r+

@bors bors
Copy link
Contributor

bors bot commented Nov 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 03bbcac into main Nov 3, 2023
8 checks passed
@bors bors bot deleted the ln/general-cb branch November 3, 2023 04:52
@juliasloan25 juliasloan25 mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysridhar akshaysridhar akshaysridhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize callbacks
2 participants
@LenkaNovak @akshaysridhar