Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable q_sfc calculation from each surface model #337

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Jun 27, 2023

Purpose

Closes #338 (see for details)


  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak self-assigned this Jun 27, 2023
@LenkaNovak LenkaNovak force-pushed the ln/add_rho_sfc_calc2 branch from 3197236 to 9efdc89 Compare June 29, 2023 22:22
@LenkaNovak LenkaNovak marked this pull request as ready for review June 30, 2023 21:49
@LenkaNovak LenkaNovak requested a review from juliasloan25 June 30, 2023 21:50
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments/questions

experiments/AMIP/modular/coupler_driver_modular.jl Outdated Show resolved Hide resolved
experiments/AMIP/modular/coupler_driver_modular.jl Outdated Show resolved Hide resolved
experiments/AMIP/modular/coupler_driver_modular.jl Outdated Show resolved Hide resolved
perf/flame.jl Show resolved Hide resolved
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LenkaNovak LenkaNovak force-pushed the ln/add_rho_sfc_calc2 branch from 445322e to 47f0d8a Compare July 1, 2023 22:48
@LenkaNovak
Copy link
Collaborator Author

LGTM!

Awesome, thank you, @juliasloan25 🚀

@LenkaNovak LenkaNovak force-pushed the ln/add_rho_sfc_calc2 branch from 47f0d8a to 20db4b2 Compare July 2, 2023 01:32
rm water check

exit debug more

less extreme ICs

liq test

rebase

bulk q_sfc test

component test fix

exit bulk test

flame fix

amip fix

clean up

clean up

fix unit tests

fix unit tests

rev

rev

rebase fix

add TD

add TD to deps
@LenkaNovak LenkaNovak force-pushed the ln/add_rho_sfc_calc2 branch from 20db4b2 to c3f5e84 Compare July 2, 2023 02:27
@LenkaNovak
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c7d84da into main Jul 2, 2023
@bors bors bot deleted the ln/add_rho_sfc_calc2 branch July 2, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable q_sfc to be calculated by each surface model
2 participants