Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tips #323

Closed
valeriabarra opened this issue Jun 15, 2023 · 1 comment
Closed

Performance tips #323

valeriabarra opened this issue Jun 15, 2023 · 1 comment
Labels
🍃 leaf Issue coupled to a PR

Comments

@valeriabarra
Copy link
Member

A few recommendations that we should always keep in mind to avoid any performance degradation that we may have introduced in some recent developments:

Try to avoid:

  • Closures over global variables (FT)
  • Use of Val when not necessary-- these symbols are not needed by the compiler, so there's no need to add them just so that we can specialize on them. (this was introduced in the update_field! in Add flux module #320 )
  • Use of parent, when not necessary (though, we saw that when exchanging quantities from fields that are not from the same space, or are from the same space but not instance (see Make swap_spaces not allocating and more GPU compatible #249 for reference) this is not possible)
@juliasloan25
Copy link
Member

will be tracked in #767

@juliasloan25 juliasloan25 closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
@juliasloan25 juliasloan25 removed this from the O1.2.6 1 SYPD for AMIP on 1 GPU milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

No branches or pull requests

3 participants