Fix column integrals for deep atmosphere #2119
Open
+123
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
column_integral_definite!
andcolumn_integral_indefinite!
functions for deep atmosphere configurations by weighting the discrete lengthsΔz
with discrete areasΔA
. Since the values ofΔA
are constant within each column when using the shallow atmosphere approximation, this change has no effect for shallow atmosphere configurations, and all current unit tests generate the same results.The purpose of this change is to fix the errors observed in the deep atmosphere PR's buildkite run, where the vertical integrals for zero-moment microphysics appear to not be conserving water mass.