Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DataLayouts #1932

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Refactor DataLayouts #1932

merged 1 commit into from
Aug 14, 2024

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Aug 14, 2024 •
edited
Loading

This PR refactors some of the internals of DataLayouts. Some of the goals are:

  • use parent less
  • use universal_size more consistently
  • Reduce code duplication
    • replace_basetype
    • Base.copy
    • rebuild
    • getproperty/_property_view
    • adapt_structure

I think/hope that helpers like type_params and union_all can perhaps eventually reduce code duplication with slab/column etc.

This is a nice contribution towards #1780 and #1928.

@charleskawczynski charleskawczynski force-pushed the ck/DL_size branch 6 times, most recently from e9f6be4 to 3982179 Compare August 14, 2024 15:04
@charleskawczynski charleskawczynski mentioned this pull request Aug 14, 2024
Closed
Sbozzolo
Sbozzolo approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Maybe you could add a docstring to union_all because it is not immediately clear how/when to use it.

@charleskawczynski
Refactor DataLayouts
60e313d 
Reduce more code duplication in DataLayouts

Reduce more code duplication

Reduce more code duplication
@charleskawczynski charleskawczynski merged commit c2451ad into main Aug 14, 2024
13 of 18 checks passed
@charleskawczynski charleskawczynski deleted the ck/DL_size branch August 14, 2024 17:02
This was referenced Aug 15, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @Sbozzolo