Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model config #3480

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Remove model config #3480

merged 1 commit into from
Dec 13, 2024

Conversation

Sbozzolo
Copy link
Member

The information is already available in the space

@Sbozzolo Sbozzolo requested a review from szy21 December 12, 2024 01:22
@Sbozzolo Sbozzolo force-pushed the gb/remove_model_config branch 4 times, most recently from 7780b9d to 8934819 Compare December 12, 2024 01:41
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe we can move is_column and is_sphere to utilities? Maybe other components will use them at some point.

@Sbozzolo Sbozzolo force-pushed the gb/remove_model_config branch from 8934819 to 866c51d Compare December 12, 2024 15:46
@Sbozzolo Sbozzolo enabled auto-merge December 12, 2024 15:48
@Sbozzolo Sbozzolo force-pushed the gb/remove_model_config branch 2 times, most recently from 1a8384b to 607efce Compare December 12, 2024 21:37
The information is already available in the space
@Sbozzolo Sbozzolo force-pushed the gb/remove_model_config branch from 607efce to 6225a90 Compare December 12, 2024 22:04
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 89047eb Dec 13, 2024
14 of 16 checks passed
@Sbozzolo Sbozzolo deleted the gb/remove_model_config branch December 13, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants