Remove WTE from cache #3464
Merged
Remove WTE from cache #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/remove_wte
branch
2 times, most recently
from
b59fd2e to
6d30ca6
Compare
|
Needs: CliMA/ClimaUtilities.jl#137 |
Sbozzolo
force-pushed
the
gb/remove_wte
branch
2 times, most recently
from
d7b0376 to
abc36d4
Compare
Sbozzolo
force-pushed
the
gb/remove_wte
branch
from
abc36d4 to
c4c87cf
Compare
Sbozzolo
force-pushed
the
gb/remove_wte
branch
4 times, most recently
from
5e96c42 to
cb0e2ed
Compare
This commit removes the `WallTimeEstimate` from the cache and moves it to an isolated place. In the process, I refactored the struct to split reporting with updating, so that reporting can be done with any frequency/schedule desired using the same Schedule infrastructure used by other functions/diagnostics as well.
Sbozzolo
force-pushed
the
gb/remove_wte
branch
from
cb0e2ed to
11f9e21
Compare
juliasloan25
approved these changes
Dec 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
WallTimeEstimatefrom the cache and moves it to an isolated place. In the process, I refactored the struct to split reporting with updating, so that reporting can be done with any frequency/schedule desired using the same Schedule infrastructure used by other functions/diagnostics as well.Closes #2992, #2935