Update Thermodynamics #3315
Merged
Update Thermodynamics #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
aj/implicit_solver_internal_energy
branch
from
1823bf1 to
0d124bc
Compare
szy21
force-pushed
the
aj/implicit_solver_internal_energy
branch
from
0d124bc to
fca6ca3
Compare
szy21
reviewed
Sep 23, 2024
szy21
reviewed
Sep 23, 2024
| T_0 = FT(CAP.T_0(params)) | ||
| R_d = FT(CAP.R_d(params)) | ||
| cp_d = FT(CAP.cp_d(params)) | ||
| ∂e_int_∂q_tot = T_0 * (Δcv_v - R_d) - FT(CAP.e_int_v0(params)) |
There was a problem hiding this comment.
(just note: This is not exactly an accurate name, but close)
szy21
force-pushed
the
aj/implicit_solver_internal_energy
branch
3 times, most recently
from
99dddb0 to
e75d605
Compare
szy21
force-pushed
the
aj/implicit_solver_internal_energy
branch
from
e75d605 to
76c5741
Compare
szy21
force-pushed
the
aj/implicit_solver_internal_energy
branch
from
5e9aa4d to
40e0e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Thermodynamics to 0.12.8 and modify Jacobian accordingly.