-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vertical diagnostics #3254
Add vertical diagnostics #3254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And after #3262 is merged, you can rebase and add compat 0.14.12 for ClimaCore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments where allocations can be removed.
Also, is this run routinely in CI? Can we add some plots to ci_plots
maybe?
f8b5a98
to
4042972
Compare
4391f68
to
73c4f15
Compare
@szy21 I added the diagnostics to defaults as requested and bumped the compat for ClimaCore |
vars_2D = map_comparison(simdirs, short_names_2D) do simdir, short_name | ||
average_xy(get(simdir; short_name, reduction)) | ||
end | ||
vars_3D = map_comparison(simdirs, short_names_3D) do simdir, short_name | ||
data = window( | ||
get(simdir; short_name, reduction), | ||
"z", | ||
left = 0, | ||
right = 4000, | ||
) | ||
return average_xy(data) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your simulation is just a column, you can slice(var, x = 0, y = 0)
to get its value
Change to using LazyBroadcast Co-authored-by: Zhaoyi Shen <[email protected]> Co-authored-by: Zhaoyi Shen <[email protected]> fixes q_vap, lazy loading, and adds clivi, lwp, renames husv Co-authored-by: Zhaoyi Shen <[email protected]> Co-authored-by: Gabriele Bozzola <[email protected]> Fixes allocations and adds ci plot for gcm_driven_scm Updates ClimaCore compat and adds new diagnostics to moist defaults formatter
a0a133c
to
f947e99
Compare
Purpose
Adds 7 vertical diagnostics:
clwvi
,dsevi
,clvi
,prw
,hurvi
,lwp
,clivi
as well as vapor specific humidityhusv
. Diagnostics are tested in the prognostic edmf gcm driven single column case, e.g.,config/model_configs/prognostic_edmfx_gcmdriven_column.yml
and in an entry to ci plotsTo-do
Edit - The following was updated:
Before merge we to fix the column vertical integral function in
ClimaCore.jl
(@dennisYatunin) by changing the third argument toFields.Δz_field(axes(ᶜinput))
fromFields.Δz_field(ᶜinput)