Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCM-driven SCM modifications #3164

Merged
merged 1 commit into from
Jul 2, 2024
Merged

GCM-driven SCM modifications #3164

merged 1 commit into from
Jul 2, 2024

Conversation

costachris
Copy link
Member

Change LES default imin index, expose surface area parameter in diagnostic EDMF, set top cell forcing tendency to zero.

@costachris costachris requested a review from szy21 July 1, 2024 23:10
szy21
szy21 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/initial_conditions/initial_conditions.jl Outdated Show resolved Hide resolved
src/prognostic_equations/forcing/external_forcing.jl Show resolved Hide resolved
@costachris costachris force-pushed the cc/gcm_driven_forcing_mod branch from eabd661 to 3550495 Compare July 1, 2024 23:52
@costachris costachris marked this pull request as ready for review July 1, 2024 23:52
@costachris costachris force-pushed the cc/gcm_driven_forcing_mod branch 2 times, most recently from c2daac0 to ec9a61b Compare July 1, 2024 23:56
@costachris costachris force-pushed the cc/gcm_driven_forcing_mod branch from ec9a61b to 6d7f9be Compare July 1, 2024 23:59
@costachris
Change LES default imin index, expose surface area parameter in diag…
e42e4e5 
…nostic EDMF, set top cell forcing tendency to zero
@costachris costachris force-pushed the cc/gcm_driven_forcing_mod branch from 6d7f9be to e42e4e5 Compare July 2, 2024 00:08
@costachris costachris added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2024
@szy21 szy21 added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2024
@szy21 szy21 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit e2ea2ca Jul 2, 2024
11 of 13 checks passed
@szy21 szy21 deleted the cc/gcm_driven_forcing_mod branch July 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@costachris @szy21