Added RCEMIPII plane sst #3157
Merged
Added RCEMIPII plane sst #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmschmitt519
force-pushed
the
zs/cs/rcemip_sst
branch
from
7f0556e to
d945548
Compare
szy21
reviewed
Jun 29, 2024
There was a problem hiding this comment.
This looks good. But I think it would be better if we make the surface_temperature function dispatch on both sfc_temperature and model_config. This way we can have only one RCEMIPII surface temperature type, but work for the sphere or box. It also help avoid the case that e.g. some users use the sphere SST for a box setup. If it is too complicated, we can get this in and refactor it in a separate PR.
cmschmitt519
force-pushed
the
zs/cs/rcemip_sst
branch
4 times, most recently
from
ff69f57 to
9acf505
Compare
Sbozzolo
reviewed
Jul 2, 2024
cmschmitt519
force-pushed
the
zs/cs/rcemip_sst
branch
3 times, most recently
from
ce2489b to
396b1c7
Compare
akshaysridhar
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Pending buildkite check; but code changes LGTM. Thanks @cmschmitt519.
cmschmitt519
force-pushed
the
zs/cs/rcemip_sst
branch
from
396b1c7 to
0d78d33
Compare
Surface condition dispatches on sfc_temp and model_config Added buildkite test add diagnostic variable remove model_config
cmschmitt519
force-pushed
the
zs/cs/rcemip_sst
branch
from
0d78d33 to
06ddc5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add RCEMIPII plane sst distribution
To-do
Content
Previously, all box models with prescribed surface temp were automatically set to 300K. I kept this logic except for the RCEMIPII case