Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rcemipii insolation, changed insolation argument #3150

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

cmschmitt519
Copy link
Member

Purpose

Add rcemipii insolation argument, and change the "idealized_insolation" argument to "insolation"
Initialized insolation variables in callback

To-do

Content


  • I have read and checked the items on the review checklist.

@cmschmitt519 cmschmitt519 requested a review from szy21 June 27, 2024 18:11
@cmschmitt519 cmschmitt519 force-pushed the cs/rcemip_insolation branch 7 times, most recently from 30a05a4 to af11aa5 Compare June 27, 2024 21:26
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

src/callbacks/callbacks.jl Outdated Show resolved Hide resolved
src/callbacks/callbacks.jl Outdated Show resolved Hide resolved
src/callbacks/callbacks.jl Outdated Show resolved Hide resolved
src/callbacks/callbacks.jl Outdated Show resolved Hide resolved
@cmschmitt519 cmschmitt519 force-pushed the cs/rcemip_insolation branch from ea21eb7 to 4a1e8e1 Compare June 27, 2024 22:21
@szy21 szy21 force-pushed the cs/rcemip_insolation branch from 4a1e8e1 to 9ddd165 Compare June 29, 2024 05:15
@szy21 szy21 enabled auto-merge June 29, 2024 05:17
@szy21 szy21 disabled auto-merge June 29, 2024 05:17
@szy21 szy21 force-pushed the cs/rcemip_insolation branch from 9ddd165 to 4ff2565 Compare June 29, 2024 05:21
@szy21 szy21 enabled auto-merge June 29, 2024 05:21
@szy21 szy21 added this pull request to the merge queue Jun 29, 2024
Merged via the queue into main with commit a40b55c Jun 29, 2024
11 of 13 checks passed
@szy21 szy21 deleted the cs/rcemip_insolation branch June 29, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants