Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

And check conservation of water also without PrognosticSurfaceTemperature #3133

Merged
merged 1 commit into from
Jul 3, 2024
Merged

And check conservation of water also without PrognosticSurfaceTemperature #3133

merged 1 commit into from
Jul 3, 2024

Conversation

Sbozzolo
Copy link
Member

And check conservation of water also without PrognosticSurfaceTemperature

@Sbozzolo Sbozzolo requested a review from szy21 June 24, 2024 21:30
szy21
szy21 reviewed Jun 24, 2024
View reviewed changes
src/solver/solve.jl Outdated Show resolved Hide resolved
src/solver/solve.jl Show resolved Hide resolved
@szy21
Copy link
Member

szy21 commented Jun 24, 2024

The issue with using t=0 is that water_total will be zero for most of the cases (where the initial condition is dry).

@Sbozzolo
Copy link
Member Author

The issue with using t=0 is that water_total will be zero for most of the cases (where the initial condition is dry).

Okay, it makes sense.

@Sbozzolo Sbozzolo changed the title Check conservation against t = 0 And check conservation of water also without PrognosticSurfaceTemperature Jun 25, 2024
@Sbozzolo Sbozzolo requested a review from szy21 June 25, 2024 15:39
@Sbozzolo
Copy link
Member Author

The issue with using t=0 is that water_total will be zero for most of the cases (where the initial condition is dry).

I rolled back to checking with end (even if I think we should not do that), and singled out the change to check water conservation also without PrognosticSurfaceTemperature.

szy21
szy21 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just keep in mind that when sfc is not Prognostic, water conservation will not hold when there is source or sink of moisture (evaporation or precipitation).

@Sbozzolo Sbozzolo force-pushed the gb/fix branch 2 times, most recently from 6f78b87 to c8d0236 Compare July 2, 2024 16:15
@Sbozzolo Sbozzolo enabled auto-merge July 2, 2024 16:34
szy21
szy21 reviewed Jul 2, 2024
View reviewed changes
src/solver/solve.jl Outdated Show resolved Hide resolved
@szy21
Copy link
Member

szy21 commented Jul 2, 2024

Actually I want to output water conservation check without PrognosticSurfaceTemperature as well. I'll push to this PR.

@Sbozzolo Sbozzolo added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit d36c0f6 Jul 3, 2024
10 of 13 checks passed
@Sbozzolo Sbozzolo deleted the gb/fix branch July 3, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sbozzolo @szy21