Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the new CloudMicrophysics interface #2303

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Update to the new CloudMicrophysics interface #2303

merged 1 commit into from
Nov 2, 2023

Conversation

trontrytel
Copy link
Member

@trontrytel trontrytel commented Oct 28, 2023 •
edited
Loading

This PR:

  • updates the 0-moment microphysics to the new parameters interface in CloudMicrophysics v0.15
  • deletes unused old EDMF + microphysics code

@trontrytel trontrytel force-pushed the aj/new_micro_interface_2 branch from 8f07a01 to 9779e03 Compare October 28, 2023 03:42
@trontrytel trontrytel changed the title Try the new CloudMicrophysics interface vol2 Update to the new CloudMicrophysics interface Oct 30, 2023
@trontrytel trontrytel marked this pull request as ready for review October 30, 2023 17:41
@trontrytel trontrytel self-assigned this Oct 30, 2023
nefrathenrici
nefrathenrici approved these changes Oct 30, 2023
View reviewed changes
src/parameters/create_parameters.jl Outdated Show resolved Hide resolved
src/parameters/create_parameters.jl Outdated Show resolved Hide resolved
@trontrytel trontrytel force-pushed the aj/new_micro_interface_2 branch 2 times, most recently from f6e1ae7 to 4160a99 Compare October 30, 2023 21:02
@trontrytel trontrytel force-pushed the aj/new_micro_interface_2 branch 2 times, most recently from cdf2597 to 53c17c3 Compare October 30, 2023 21:54
@trontrytel
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 31, 2023

Merge conflict.

@trontrytel trontrytel force-pushed the aj/new_micro_interface_2 branch 3 times, most recently from 0099920 to 7d8b178 Compare November 1, 2023 20:40
@trontrytel trontrytel force-pushed the aj/new_micro_interface_2 branch from 7d8b178 to cf290f0 Compare November 1, 2023 23:10
@trontrytel
Copy link
Member Author

bors r+

1 similar comment
@szy21
Copy link
Member

szy21 commented Nov 2, 2023

bors r+

@bors bors bot merged commit 6bf3411 into main Nov 2, 2023
6 checks passed
@bors bors
Copy link
Contributor

bors bot commented Nov 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot deleted the aj/new_micro_interface_2 branch November 2, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nefrathenrici nefrathenrici nefrathenrici approved these changes

@sriharshakandala sriharshakandala sriharshakandala approved these changes

@szy21 szy21 szy21 approved these changes

Assignees

@trontrytel trontrytel

Labels
ClimaParameters 🎛️ Microphysics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trontrytel @szy21 @sriharshakandala @nefrathenrici