separate precomputed quantities in 3 funcs #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
approved these changes
Oct 24, 2023
Yes, I can do it in the next one. Just wasn't sure if this is actually helpful or not |
trontrytel
force-pushed
the
aj/edmf_cleanup
branch
from
922749b to
5253b28
Compare
|
bors r+ |
|
It's a step in the right direction. Thanks :) |
bors bot
added a commit
that referenced
this pull request
Oct 24, 2023
2274: separate precomputed quantities in 3 funcs r=trontrytel a=trontrytel Following what we discussed `@szy21` , `@Sbozzolo` this PR splits prognostic edmfx precomputed quantities into 3 steps 1) updating environment 2) updating updraft thermo state and BC 3) updating the closures. I'm not sure if it actually makes anything better though. Or if you want to split the individual closures. Co-authored-by: Anna Jaruga <[email protected]>
|
Build failed: |
|
bors r+ |
trontrytel
force-pushed
the
aj/edmf_cleanup
branch
from
5253b28 to
d45dd3a
Compare
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 24, 2023
2274: separate precomputed quantities in 3 funcs r=trontrytel a=trontrytel Following what we discussed `@szy21` , `@Sbozzolo` this PR splits prognostic edmfx precomputed quantities into 3 steps 1) updating environment 2) updating updraft thermo state and BC 3) updating the closures. I'm not sure if it actually makes anything better though. Or if you want to split the individual closures. 2284: Remove explicit use of CUDA in benchmark_step r=charleskawczynski a=charleskawczynski This PR removes an explicit use of CUDA in `benchmark_step!`, so that we have no direct package loading of CUDA. Co-authored-by: Anna Jaruga <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Oct 24, 2023
2274: separate precomputed quantities in 3 funcs r=trontrytel a=trontrytel Following what we discussed `@szy21` , `@Sbozzolo` this PR splits prognostic edmfx precomputed quantities into 3 steps 1) updating environment 2) updating updraft thermo state and BC 3) updating the closures. I'm not sure if it actually makes anything better though. Or if you want to split the individual closures. 2282: Increase job memory for perf jobs and lower allocations r=Sbozzolo a=Sbozzolo Co-authored-by: Anna Jaruga <[email protected]> Co-authored-by: Gabriele Bozzola <[email protected]>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Oct 25, 2023
2274: separate precomputed quantities in 3 funcs r=trontrytel a=trontrytel Following what we discussed `@szy21` , `@Sbozzolo` this PR splits prognostic edmfx precomputed quantities into 3 steps 1) updating environment 2) updating updraft thermo state and BC 3) updating the closures. I'm not sure if it actually makes anything better though. Or if you want to split the individual closures. Co-authored-by: Anna Jaruga <[email protected]>
|
Build failed: |
trontrytel
force-pushed
the
aj/edmf_cleanup
branch
from
d45dd3a to
594c8fd
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following what we discussed @szy21 , @Sbozzolo this PR splits prognostic edmfx precomputed quantities into 3 steps
I'm not sure if it actually makes anything better though. Or if you want to split the individual closures.