Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert histogram metrics #18

Merged
merged 2 commits into from
Jul 18, 2024
Merged

convert histogram metrics #18

merged 2 commits into from
Jul 18, 2024

Conversation

Keksoj
Copy link
Contributor

@Keksoj Keksoj commented Jul 16, 2024

  1. Sōzu now aggregates metrics accross workers, no need to do it anymore
  2. Sōzu now produces prometheus-compatible histograms, we can convert them to metric lines.

@Keksoj Keksoj changed the title Bump to sozu 1.1, histograms draft: Bump to sozu 1.1, histograms Jul 16, 2024
llenotre
llenotre reviewed Jul 17, 2024
View reviewed changes
src/svc/telemetry/prometheus.rs Show resolved Hide resolved
src/svc/telemetry/prometheus.rs Outdated Show resolved Hide resolved
src/svc/telemetry/prometheus.rs Show resolved Hide resolved
@Keksoj Keksoj force-pushed the bump-to-sozu-1.1 branch from 2674eba to b3962d3 Compare July 17, 2024 15:40
Emmanuel Bosquet added 2 commits July 18, 2024 14:48
bump to Sōzu 1.0.3: remove aggregation of metrics
7ce78b8 
Now Sōzu aggregates metrics by worker and cluster
convert histograms metrics
e405175 
each histogram produced by Sōzu yields 4 kinds of lines:
- a type line
- a sum line
- a cound line
- several bucket lines
@Keksoj Keksoj force-pushed the bump-to-sozu-1.1 branch from b3962d3 to e405175 Compare July 18, 2024 12:51
@Keksoj Keksoj changed the title draft: Bump to sozu 1.1, histograms convert histogram metrics Jul 18, 2024
llenotre
llenotre approved these changes Jul 18, 2024
View reviewed changes
Copy link

@llenotre llenotre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Keksoj Keksoj merged commit b9dc09d into main Jul 18, 2024
8 checks passed
@Keksoj Keksoj deleted the bump-to-sozu-1.1 branch July 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llenotre llenotre llenotre approved these changes

@FlorentinDUBOIS FlorentinDUBOIS Awaiting requested review from FlorentinDUBOIS FlorentinDUBOIS is a code owner

@Wonshtrum Wonshtrum Awaiting requested review from Wonshtrum Wonshtrum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keksoj @llenotre